Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixel_unshuffle function added for Paddle Frontend #21754

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Sameerk22
Copy link
Contributor

@Sameerk22 Sameerk22 commented Aug 12, 2023

Close #21596

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 12, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

Copy link
Contributor

@zaeemansari70 zaeemansari70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly un-commit the changes in the .idea folder.
Thanks!

@Sameerk22
Copy link
Contributor Author

Kindly un-commit the changes in the .idea folder. Thanks!
Done

@Sameerk22 Sameerk22 closed this Aug 24, 2023
@Sameerk22 Sameerk22 reopened this Aug 24, 2023
@Sameerk22
Copy link
Contributor Author

The changes requested by the reviewer i.e. Zaeem Ansari are done and I have reponed the pull request.

@paulaehab
Copy link
Contributor

Hello @Sameerk22 first sorry for late reply, thanks for your contributing first to review this PR the edits must be the 2 files related to the function vision.py and test_vision.py so I can review the function and merge the PR.please remove all edits and changes in the other file so the file changes be these two files only.

@Sameerk22
Copy link
Contributor Author

Hi! @paulaehab
Thanks for reaching out.
By deleting the files from this pull request will solve it? Like I did for 2 files?

@Sameerk22
Copy link
Contributor Author

Kindly check.
Now I have only 2 files (the required ones) with changes.

@paulaehab
Copy link
Contributor

Hi @Sameerk22 again I am very sorry for late reply, I mean you should have the File changed contain only the needed file so if may be you can un commit your commit because the changes files may affect our repo.
Also, I have test the function, and it works fine great work, and thanks for your contributing 👍it just failing for paddle and torch backend just take a llok at them both but totally great work 😄

@Sameerk22
Copy link
Contributor Author

Hi @paulaehab .
So i reseted those commits but from where I did that these 2 files (i.e. tensor.py & test_tensor.py )were also present so I though this should come along. There is no conflict or change in it. But those unnecessary files are now gone.
Kindly check.

@paulaehab
Copy link
Contributor

Hi @paulaehab . So i reseted those commits but from where I did that these 2 files (i.e. tensor.py & test_tensor.py )were also present so I though this should come along. There is no conflict or change in it. But those unnecessary files are now gone. Kindly check.

Yeah that is working fine right now but there is 2 different files added of torch (tensor.py and test_tensor.py) could you check that and remove them and I will merge the PR, thanks for your contributing 👍

@Sameerk22
Copy link
Contributor Author

Hi @paulaehab . So i reseted those commits but from where I did that these 2 files (i.e. tensor.py & test_tensor.py )were also present so I though this should come along. There is no conflict or change in it. But those unnecessary files are now gone. Kindly check.

Yeah that is working fine right now but there is 2 different files added of torch (tensor.py and test_tensor.py) could you check that and remove them and I will merge the PR, thanks for your contributing 👍

Hi! @paulaehab
So finally, I have made all the changes as required.
Now waiting for you to merge it.
And Thank You! It was great interacting.

@Sameerk22
Copy link
Contributor Author

@paulaehab

@paulaehab
Copy link
Contributor

Hey @Sameerk22 lgt thanks for contributing 😄

@paulaehab paulaehab merged commit a9c3583 into ivy-llc:main Sep 14, 2023
116 of 133 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pixel_unshuffle
4 participants